I agree that the method may add a degree of complexity up front, but, in this case, I think that the readability advantage outweighs the slight indirection. I was hoping that the method would actually be automatically “in-lined”, but apparently it is not. Regardless, it’s really a matter of personal choice.

Just to play “devil’s advocate” for a second. “Better”, in this case, must only used when referring to code reability. Is it more readable and definitely more terse. However, the code that was ‘inline’ has now been moved into a method. This requires more overhead… although not that much overhead. But, it should still be in the back of your mind that there are probably two to three times the number of instructions that must execute to achieve what was previously inlined.

- Wil